Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tabs] Fix TabIndicatorProps prop missing sx prop #32503

Merged
merged 2 commits into from
May 2, 2022
Merged

[Tabs] Fix TabIndicatorProps prop missing sx prop #32503

merged 2 commits into from
May 2, 2022

Conversation

b-novikov-ipersonality
Copy link
Contributor

@b-novikov-ipersonality b-novikov-ipersonality commented Apr 29, 2022 •
edited by siriwatknp
Loading

closes #32490

Adds sx prop to TabIndicatorProps type

@b-novikov-ipersonality b-novikov-ipersonality mentioned this pull request Apr 29, 2022
Closed
2 tasks
@mui-bot
Copy link

mui-bot commented Apr 29, 2022 •
edited
Loading

No bundle size changes

Generated by 🚫 dangerJS against 563af76

@siriwatknp siriwatknp added the PR: needs test The pull request can't be merged label Apr 29, 2022
@siriwatknp
Copy link
Member

@b-novikov-ipersonality Please add a test to packages/mui-material/src/Tabs/Tabs.spec.tsx. It is the file for testing that typings are working.

@siriwatknp siriwatknp added component: tabs This is the name of the generic UI component, not the React module! typescript labels Apr 29, 2022
@b-novikov-ipersonality
Copy link
Contributor Author

@siriwatknp added the test

siriwatknp
siriwatknp approved these changes Apr 29, 2022
View reviewed changes
Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks for your first contribution!

@ZeeshanTamboli ZeeshanTamboli removed the PR: needs test The pull request can't be merged label Apr 29, 2022
@ZeeshanTamboli ZeeshanTamboli changed the title fix: TabIndicatorProps component missing sx prop [Tabs] Fix TabIndicatorProps prop missing sx prop Apr 29, 2022
@siriwatknp siriwatknp merged commit 4d49b7a into mui:master May 2, 2022
@hzhz hzhz mentioned this pull request Jun 24, 2023
Open
@hzhz hzhz mentioned this pull request May 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siriwatknp siriwatknp siriwatknp approved these changes

Assignees
No one assigned
Labels
component: tabs This is the name of the generic UI component, not the React module! typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TabIndicatorProps prop on Tabs component is missing sx prop
5 participants
@b-novikov-ipersonality @mui-bot @siriwatknp @ZeeshanTamboli @bnn1