[Progress] Remove style propable mixin #3233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
90 tasks
| }, | ||
| }; | ||
|
|
||
| autoPrefix.set(styles.wrapper, 'transitionTimingFunction', 'linear', state.muiTheme); |
There was a problem hiding this comment.
current set implementation:
set(style, key, value) {
style[key] = value;
},just add: transitionTimingFunction: 'linear', to styles.wrapper 😁
There was a problem hiding this comment.
Yeah good call. 👍 After the migration I'd like to revisit seeing if we can get rid of all the autoPrefix calls...
newoga
force-pushed
the
#2852/progress
branch
from
8e6de45 to
fea3358
Compare
|
Thanks a lot 😁 All good 🍏 |
|
@newoga Thanks! |
oliviertassinari
added a commit
that referenced
this pull request
Feb 8, 2016
[Progress] Remove style propable mixin
zannager
added
the
package: styles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These components could use some refactoring. I started some of it, but
refresh-indicatorin particular could be improved a lot. There is some common logic that's duplicated such as thegetRelativeValue()function. Maybe one day we can consider making a single<Progress />component that can have different prop or child implementations.