[SelectUnstyled] Improve exported types #30895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaldudak
added
component: select
mnajdova
reviewed
Feb 3, 2022
| @@ -29,7 +29,7 @@ export interface SelectUnstyledCommonProps { | |||
| componentsProps?: { | |||
| root?: React.ComponentPropsWithRef<'button'> & SelectUnstyledComponentsPropsOverrides; | |||
| listbox?: React.ComponentPropsWithRef<'ul'> & SelectUnstyledComponentsPropsOverrides; | |||
| popper?: React.ComponentPropsWithRef<typeof PopperUnstyled> & | |||
| popper?: Partial<React.ComponentPropsWithRef<typeof PopperUnstyled>> & | |||
There was a problem hiding this comment.
Popper requires an open prop, but it's not necessary to provide it here in componentsProps.
There was a problem hiding this comment.
Alright, could we leave an comment for it?
| <SelectUnstyled | ||
| componentsProps={{ | ||
| root: { | ||
| // @ts-expect-error - requires module augmentation |
There was a problem hiding this comment.
Do we have test for the module augmentation?
|
👋 The migration PR has been merged. Please follow these steps to make sure that the contents are all updated. (Sorry for the inconvenience)
If you are struggle with the steps above, feel free to tag @siriwatknp |
mnajdova
approved these changes
Feb 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #30870