Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Add missing import to RTL guide #30891

Merged
merged 4 commits into from
Feb 6, 2022
Merged

[docs] Add missing import to RTL guide #30891

merged 4 commits into from
Feb 6, 2022

Conversation

CFarhad
Copy link
Contributor

@CFarhad CFarhad commented Feb 3, 2022

i added createtheme method to step 2 in Right-to-left guide because any new users dont know where is this method

@mui-bot
Copy link

mui-bot commented Feb 3, 2022

No bundle size changes

Generated by 🚫 dangerJS against 568cacc

Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch! It's a great first pull request on MUI 👌 Thank you for working on it!

@danilo-leal danilo-leal changed the title Add createTheme to sep 2 [docs] Add createTheme to step 2 Feb 3, 2022
@danilo-leal danilo-leal added the docs Improvements or additions to the documentation label Feb 3, 2022
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Feb 4, 2022
@siriwatknp
Copy link
Member

👋 The migration PR has been merged.

Please follow these steps to make sure that the contents are all updated. (Sorry for the inconvenience)

  1. pull latest master from upstream to your branch
  2. if your PR has changes on the *.md or demo files, you are likely to encounter conflict because all of them have been moved to the new folder.
    2.1 revert the change on those markdown files you did
    2.2 pull latest master from upstream (you should not see conflict)
    2.3 make the changes again at docs/data/material/*
  3. run yarn docs:api
    • you might see the changes in docs/pages/material/api/* if your PR touches some of the components
    • it is okay if there is no changes

If you are struggle with the steps above, feel free to tag @siriwatknp

@hbjORbj hbjORbj changed the title [docs] Add createTheme to step 2 [docs] Add missing import to RTL guide Feb 4, 2022
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Feb 4, 2022
@hbjORbj hbjORbj merged commit 9c30458 into mui:master Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants