[docs] Update Instructions for Google Maps Autocomplete #30849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For autocomplete to work with Google Maps Javascript API, Google's Places API also needs to be enabled. In addition you need to supply `libraries=places` as additional parameter to `loadScript` function. ```js loadScript( 'https://maps.googleapis.com/maps/api/js?key=API_KEY&libraries=places', document.querySelector('head'), 'google-maps' ); ```
danilo-leal
changed the title
danilo-leal
reviewed
Jan 31, 2022
Co-authored-by: danilo leal <[email protected]>
oliviertassinari
added
bug 🐛
oliviertassinari
force-pushed
the
patch-1
branch
from
83925a3 to
2ce0c42
Compare
|
Actually, the demo in the documentation is broken: https://mui.com/components/autocomplete/#google-maps-place
I have pushed a new commit that whitelists mui.com and Netlify to run it
And now, it works https://deploy-preview-30849--material-ui.netlify.app/components/autocomplete/#google-maps-place :) |
|
@kjschabra Thanks for raising the issue |
wladimirguerra
pushed a commit
to wladimirguerra/material-ui
that referenced
this pull request
Feb 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For autocomplete to work with Google Maps Javascript API, Google's Places API also needs to be enabled.