Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Snackbar] Ensure messages are announced in NVDA+FF #30774

Merged
merged 5 commits into from
Feb 7, 2022
Merged

[Snackbar] Ensure messages are announced in NVDA+FF #30774

merged 5 commits into from
Feb 7, 2022

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Jan 25, 2022 •
edited
Loading

Closes #29080

Courtesy of @feerrenrut (original source: nvaccess/nvda#13262 (comment))

There's more work to be done directly in ClickAwayListener either via automatic patching of role="presentation" or added warnings. But this can be done in a follow-up.

Test plan

@eps1lon eps1lon added accessibility a11y component: snackbar This is the name of the generic UI component, not the React module! labels Jan 25, 2022
@mui-bot
Copy link

mui-bot commented Jan 25, 2022 •
edited
Loading

Details of bundle changes

Generated by 🚫 dangerJS against 1fc2e70

@eps1lon eps1lon marked this pull request as ready for review January 25, 2022 14:14
@eps1lon eps1lon mentioned this pull request Jan 25, 2022
Closed
2 tasks
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Feb 4, 2022
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Feb 4, 2022
siriwatknp
siriwatknp approved these changes Feb 4, 2022
View reviewed changes
Copy link
Member

@siriwatknp siriwatknp left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@siriwatknp siriwatknp merged commit d7f9b4e into mui:master Feb 7, 2022
@eps1lon eps1lon deleted the fix/snackbar/ff-nvda-announcement branch February 7, 2022 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siriwatknp siriwatknp siriwatknp approved these changes

Assignees
No one assigned
Labels
accessibility a11y component: snackbar This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Snackbars not read by screen reader
3 participants
@eps1lon @mui-bot @siriwatknp