Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Remove ul with div children and replace with nav element #30534

Merged
merged 1 commit into from
Feb 7, 2022
Merged

[docs] Remove ul with div children and replace with nav element #30534

merged 1 commit into from
Feb 7, 2022

Conversation

joeframbach
Copy link
Contributor

@joeframbach joeframbach commented Jan 8, 2022 •
edited
Loading

The existing nav structure was:

<ul>
  <div>
    <div aria-role="button">...</div>
  </div>
  <hr>
  <div>
    <div aria-role="button">...</div>
  </div>
</ul>

This PR replaces with the semantic

<nav>
  <div aria-role="button">...</div>
  <hr>
  <div aria-role="button">...</div>
</nav>

@mui-pr-bot
Copy link

mui-pr-bot commented Jan 8, 2022 •
edited
Loading

No bundle size changes

Generated by 🚫 dangerJS against 097c304

mnajdova
mnajdova approved these changes Jan 12, 2022
View reviewed changes
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct, thanks for the contribution 👌

@mnajdova
Copy link
Member

For fixing the CI, you would need to run:

yarn prettier
yarn docs:typescript:formatted

@michaldudak
Copy link
Member

Also please take a look at Argos - after the change the margin around the menu separator is smaller.

@danilo-leal danilo-leal added the docs Improvements or additions to the documentation label Jan 14, 2022
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Feb 4, 2022
@siriwatknp siriwatknp force-pushed the example-nav-semantic branch from 097c304 to 894e280 Compare February 7, 2022 10:54
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Feb 7, 2022
@mui-bot
Copy link

mui-bot commented Feb 7, 2022 •
edited
Loading

No bundle size changes

Generated by 🚫 dangerJS against 894e280

@siriwatknp siriwatknp merged commit c3beda9 into mui:master Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnajdova mnajdova mnajdova approved these changes

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@joeframbach @mui-pr-bot @mnajdova @michaldudak @mui-bot @siriwatknp @danilo-leal