-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TextField][InputLabel] Remove pointer-events: none
property
#30493
Conversation
pointer-events: none
propertypointer-events: none
property
pointer-events: none
propertypointer-events: none
property
👍 for doing the investigation work on why this style is here in the first place. However, while in
I would classify these two as regressions, at least very close to. In https://deploy-preview-30493--material-ui.netlify.app/components/autocomplete/#combo-box, it's definitely a regression, the popup does no longer open on focus. Looking at #30488 "I want to render a Tooltip wrapped help icon on the label of the outlined input.", this seems like a OK-ish use case. It's not the best UX I would argue (=> use the helper text), but still valid. What might work is to only apply this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As @oliviertassinari mentioned, hover does not display style is a bug.
I think this is a reasonable compromise. Please check out codesandbox. |
pointer-events: none
propertypointer-events: none
property
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Nice fix.
https://deploy-preview-30493--material-ui.netlify.app/components/text-fields/#customization |
Closes #30488
Issue:
TextField
and itsInputLabelProps
prop, which is passed toInputLabel
component, event handlers (e.g.,onClick
,onFocus
) passed toInputLabelProps
don't work.Soluition:
pointer-events: none
will fix the current issue.pointer-events: none
, the old issue no longer appears. Proof