[docs] Redirect old urls to /material/* when search
#30286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnajdova
approved these changes
Dec 20, 2021
| @@ -298,7 +299,7 @@ export default function AppSearch() { | |||
| } | |||
|
|
|||
| // TODO: remove this logic once the migration to new structure is done. | |||
| if (router.asPath.startsWith('/material')) { | |||
| if (FEATURE_TOGGLE.enable_product_scope) { | |||
| parseUrl.href = parseUrl.href.replace( | |||
| /(?<!material\/)(getting-started|components|api|customization|guides|discover-more)(\/[^/]+\/)/, | |||
| `material/$1$2`, | |||
There was a problem hiding this comment.
Is this enough? When I run
'https://mui.com/components/alert/'.replace(
/(?<!material\/)(getting-started|components|api|customization|guides|discover-more)(\/[^/]+\/)/,
`material/$1$2`,
)I get https://mui.com/material/components/alert/ as an output. Based on https://www.notion.so/mui-org/Documentation-per-product-decision-time-d9347d7d37b641129d2fea12d68555d2. Should we get https://mui.com/material/react-alert/?
There was a problem hiding this comment.
The idea is to keep url the same to not have many broken things but the correct URL will be handled before the migration time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cover all scenarios when searching with cmd+K (algolia search):
Before migration
The feature toggle is not turned on, so the behavior is still the same.
Migration phase
When the contents are duplicated to
docs/pages/material/*and the feature toggle is turned on, all the search results (related to components, API, etc.) are replaced to point to/material/*URL.Post migration
The search config on the doc search is updated and the new
/material/*have been indexed, the URL will not be replaced because of the regex in the code.✅ E2E website added.