[AutoComplete] set canAutoPosition to false for PopOver

[aweary]

Fixes #2725

[alitaheri]

@oliviertassinari @newoga Please take a look at this too.

[alitaheri]

Although this still doesn't fully address the issue. It makes it better for the time being. I'd be ok for this to be merged. But We should improve it further in the future. @oliviertassinari Do you think it's a breaking change?

[aweary]

I'd be completely open to a more robust solution. If someone familiar with the implementation can point me in the right direction, I'd be happy to work on it.

[newoga]

I know very little about the Popover component, unfortunately. 😅 Though from what I've seen, I think the Popover could use some implementation tidying.

Based on #2725, personally I think the current "jumping around" behavior as it relates to AutoComplete is just wrong and I don't think @aweary's change in this PR is a breaking change because the current behavior is broken anyway. I think for AutoComplete, the results should just show below, so if this improves it at all, I think it's fine. This behavior makes a little bit more sense from a DropDownMenu perspective where the currently selected result shouldn't show below but inline.

If we want to fix this particular issue properly, I think we're going to have to start with the Popover though, not the AutoComplete (though AutoComplete could use some improvements too).

[newoga]

Also, I could make an argument it was a breaking change when the AutoComplete switched to using the Popover in the first place because the original behavior was to just show the results below all the time if my memory serves me correctly.

[newoga]

@oliviertassinari I know you were looking at some <AutoComplete /> stuff recently, any thoughts on this?

[mbrookes]

Note sure how a one-line change can have a merge conflict (!), but this looks like a sensible fix until the underlying behaviour is resolved.

@aweary please rebase and we'll merge.

[mbrookes]

Ping @aweary 😄

(If you're busy, let me know and I'll fix it up. 👌 )

[aweary]

Ah, missed your last ping! I'll get this rebased tonight

[mbrookes]

Thanks! 👍

[aweary]

@mbrookes merge conflicts are resolved, though I was having some trouble squashing the commits.

[alitaheri]

@aweary you will need to git push origin autocomplete-auto-position --force after you git rebase upstream/master -i

[aweary]

@alitaheri did that 👍

[alitaheri]

It's better, but there is another merge commit that needs to be removed. if it proves to be hard. just git reset upstream/mater --hard and reapply your change then force push.

[aweary]

@alitaheri I did exactly that and the extra commit didn't go away 😖 I think it's related to the fact that I merged in a bunch of changes to my fork's master and then to this branch.

I can just open a new PR with the change if it matters. Not like its a big change 😛

[alitaheri]

Yeah that also works 😆 you can also delete this branch and reopen it with the exact same name wherever you want 😁

[aweary]

Opened new PR at #3620