[core] Remove --exact from release:version
#28840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siriwatknp
requested review from
eps1lon,
mnajdova and
a team
and removed request for
mnajdova and
eps1lon
|
Sounds like you didn't actually test this? |
Sorry, I should have mentioned that it is tested locally (carets are applied). |
|
@siriwatknp does this takes into account the |
No, caret also added to the packages with alpha version. I will add some note in README to remove the caret for alpha versions. |
siriwatknp
force-pushed
the
release-without-exact
branch
from
c9edc1e to
664a830
Compare
mnajdova
reviewed
Oct 6, 2021
mnajdova
approved these changes
Oct 6, 2021
siriwatknp
commented
Oct 6, 2021
michaldudak
approved these changes
Oct 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will help us not to manually update the version with
^when doing release. @michaldudak please try it out in this release and see if there is any error with this change.