Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[InputLabel] Fix condition for applying formControl overrides #28707

Merged
merged 1 commit into from
Sep 30, 2021
Merged

[InputLabel] Fix condition for applying formControl overrides #28707

merged 1 commit into from
Sep 30, 2021

Conversation

yevheniiminin
Copy link
Contributor

@yevheniiminin yevheniiminin commented Sep 30, 2021 •
edited by oliviertassinari
Loading

Inverse the condition to correctly apply formControl styles when formControl=true
Fixes #28686

@yevheniiminin yevheniiminin mentioned this pull request Sep 30, 2021
Closed
2 tasks
@eps1lon eps1lon requested a review from mnajdova September 30, 2021 09:34
@mui-pr-bot
Copy link

mui-pr-bot commented Sep 30, 2021 •
edited
Loading

Details of bundle changes

Generated by 🚫 dangerJS against 7d35dfc

mnajdova
mnajdova approved these changes Sep 30, 2021
View reviewed changes
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a great first pull requset on MUI 👌 Thank you for working on it!

@mnajdova mnajdova changed the title Correctly apply formControl styles when property is passed [InputLabel] Fix condition for applying formControl overrides Sep 30, 2021
@mnajdova mnajdova merged commit 3e679ac into mui:master Sep 30, 2021
@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work component: text field This is the name of the generic UI component, not the React module! labels Sep 30, 2021
@yevheniiminin yevheniiminin deleted the inputlabel-formcontrol-issue branch September 30, 2021 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnajdova mnajdova mnajdova approved these changes

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: text field This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong behavior when overriding formControl style of InputLabel
4 participants
@yevheniiminin @mui-pr-bot @mnajdova @oliviertassinari