Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Use PNG instead of SVG for color preview #28699

Merged
merged 6 commits into from
Oct 7, 2021

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Sep 29, 2021

Closes #28659

Published packages remain broken.

For security reasons VSCode no longer displays SVGs.

PNGs were created with svgexport input.svg output.png 24:24

  • redirects from *.svg to *.png are not possible with netlify
  • sending image/png from *.svg is not displayed in vscode

@eps1lon eps1lon added bug 🐛 Something doesn't work package: material-ui Specific to @mui/material labels Sep 29, 2021
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Sep 29, 2021
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Sep 30, 2021
@mui-pr-bot
Copy link

mui-pr-bot commented Sep 30, 2021

No bundle size changes

Generated by 🚫 dangerJS against 3121a54

- redirects from *.svg to *.png aren't working
- image/png from *.svg is not displayed by vscode
@eps1lon eps1lon marked this pull request as ready for review September 30, 2021 09:16
@eps1lon eps1lon merged commit f002835 into mui:master Oct 7, 2021
@eps1lon eps1lon deleted the fix/color-preview branch October 7, 2021 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work package: material-ui Specific to @mui/material
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use rendered graphics like PNG files instead of SVG in documentation
2 participants