-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Uniformize the code's font family #28582
[docs] Uniformize the code's font family #28582
Conversation
|
@siriwatknp Ok, fair enough, I have reverted the font-size change, it's 13px now on the docs. Ant Design uses 13px, GitHub 11px. VS Code, in my environment, feels like 13.5px by default React.js 14px. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Before: https://mui.com/components/alert/#basic-alerts
After: https://deploy-preview-28582--material-ui.netlify.app/components/alert/#basic-alerts
This is an effort to simplify the font logic. We were using two different font families for the marketing and docs. We are now only using one. We are using the built-in fonts, which are more performant (to load), and closer to what developers might already be used to. However, it doesn't give us a unique brand identity feel.
We also did a couple of side cleaning: