[test] Make seconds views test pass in browsers
#28511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
added
test
component: date time picker
|
@eps1lon I am kind of lost. Could you share why the tests were failing before, but are passing now? Just trying to understand :) |
|
@mnajdova See updated PR description |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests added in #25095 assumed
DatePickerwould render aMobileDatePicker. But that depends on the environment. For us that meant that browser tests were failing while headless tests were passing (because different components were rendered). The actual feature is only supported by theMobileDatePickerso let's just test it for that component.Browser pass: https://app.circleci.com/pipelines/github/mui-org/material-ui/52746/workflows/6ae67665-93b2-404e-a3ab-b01acc38b759/jobs/299238 (failures are unrelated)