Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[website] Update /company pages to use marketing website Header and Footer #28498

Merged
merged 3 commits into from
Sep 21, 2021

Conversation

danilo-leal
Copy link
Contributor

@danilo-leal danilo-leal commented Sep 20, 2021

  • I have followed (at least) the PR section of the contributing guide.

  • Updated the file TopLayoutCompany to use the AppHeader and AppFooter used in the marketing pages instead of the documentation ones (footer was already outdated though).

  • Added a link to the role pages linking back to the Open Roles section on the Careers page.

Deploy preview →

@danilo-leal danilo-leal added the website Pages that are not documentation-related, marketing-focused. label Sep 20, 2021
@mui-pr-bot
Copy link

mui-pr-bot commented Sep 20, 2021

No bundle size changes

Generated by 🚫 dangerJS against 4642f46

Copy link
Member

@mbrookes mbrookes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't reviewed the code, just happy with the change based on the preview.

docs/pages/careers.tsx Outdated Show resolved Hide resolved
docs/src/modules/components/TopLayoutCompany.js Outdated Show resolved Hide resolved
@siriwatknp
Copy link
Member

siriwatknp commented Sep 21, 2021

@oliviertassinari @danilo-leal I used this opportunity to migrate makeStyles to emotion.

@danilo-leal danilo-leal merged commit 23372a1 into mui:master Sep 21, 2021
@danilo-leal danilo-leal deleted the update-company-layout branch September 21, 2021 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
website Pages that are not documentation-related, marketing-focused.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants