[Checkbox] Fix form submission with empty value #28423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@garronej Cool. Could you add a test case for it? With the unstyled effort, we will likely refactor this part of the codebase. |
oliviertassinari
changed the title
oliviertassinari
added
bug 🐛
@oliviertassinari done 👍🏻 |
oliviertassinari
approved these changes
Sep 21, 2021
mnajdova
approved these changes
Sep 22, 2021
oliviertassinari
changed the title
|
Sebastian is off, merging as the change is well tested (it fails without the fix) and there is a clear reproduction. @garronej Thanks, well done |
|
Referencing facebook/react#17590 here which is why we need this workaround. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Mui checkboxes, when used in a
<form>, don't submit their values.Screen.Recording.2021-09-18.at.15.58.09.mov
Playground link
This is due to the fact that, if we put a
valueprop to the<input />, even if it'sundefined, it ends up as an html property and at the time of submiting the form will be interpreted as a void string overriding the checked value.This PR fixes it but maybe it would be better to fix it upstream.
Best regards,
PS: The new landing page is very cool.