Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Lazily import fixtures #28239

Merged
merged 1 commit into from
Sep 14, 2021
Merged

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Sep 9, 2021

Previously all fixtures were bundled in a single chunk. We can use dynamic import() instead to split the the file up into multiple chunks. This has only minor implications during development since the browser no longer has to evaluate 14MB of JavaScript on landing (initial chunk is down to 3MB).

It's mainly done now to enable lazyCompilation once it's stable. Lazily compiling the demos will be the major booster since we could basically have a very fast cold start and then compile the next demos while running the test i.e. compilation and test will be concurrent.

@eps1lon eps1lon added the test label Sep 9, 2021
@mui-pr-bot
Copy link

mui-pr-bot commented Sep 9, 2021

No bundle size changes (experimental)

Generated by 🚫 dangerJS against 2a57dfd

@eps1lon eps1lon marked this pull request as ready for review September 9, 2021 12:11
@eps1lon eps1lon changed the base branch from next to master September 14, 2021 09:13
@eps1lon eps1lon merged commit cd1151a into mui:master Sep 14, 2021
@eps1lon eps1lon deleted the test/lazy-regressions branch September 14, 2021 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants