[docs] Push the fixes on Next.js's Link to the examples #28178
Conversation
oliviertassinari
force-pushed
the
sync-link-component
branch
from
804c4e1 to
40615fc
Compare
oliviertassinari
force-pushed
the
sync-link-component
branch
from
40615fc to
8a15a4f
Compare
| import { styled } from '@mui/material/styles'; | ||
|
|
||
| // Add support for the sx prop for consistency with the other branches. | ||
| const Anchor = styled('a')({}); |
There was a problem hiding this comment.
Please keep the example minimal. There is no need to add another learning layer. Consistency is not a target.
There was a problem hiding this comment.
It's meant as a bug fix. This style allows getting the sx prop no matter the params (using external links or not). I believe @siriwatknp added it because it noticed that it wasn't always present.
There was a problem hiding this comment.
I have created https://codesandbox.io/s/polished-wood-31j6t?file=/pages/index.js to illustrate the bug fixed
oliviertassinari
dismissed
eps1lon’s stale review
I think that there should be a single Link component source branch (even if the source are duplicated between files). If we are feel the source gets too complicated, then its the sign that we need to expose dedicated component from MUI, e.g. '@mui/material/NextLink'.
hreffor AppDrawerNavItems #27936 to remove the support for thepassHrefprop, it doesn't make sense in our context.reftype fromcomponent#28101 to remove the typecasting, TypeScript is also smarter in the latest version.cursor: pointeras it was previously hiding a root issue, and we never need it.