Update TimePicker am/pm buttons #2757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(aim to fix #2323) |
oliviertassinari
added
PR: Needs Review
design: material
|
The PR: The spec: @netoctone That looks good 👍 |
| position: 'relative', | ||
| lineHeight: '17px', | ||
| height: 17, | ||
| fontSize: '17px', |
There was a problem hiding this comment.
fontSize: 17, is enough.
| {min} | ||
| </span> | ||
| <div style={this.prepareStyles(styles.text)}> | ||
| <div style={this.prepareStyles(styles.affix)} /> |
There was a problem hiding this comment.
switched from invisible text to flexbox
looks a bit cleaner
will check on IE/Safari later
There was a problem hiding this comment.
I have tested it on Safari, latest version.
That's better like this.
For IE, I let you test it.
Otherwise, I'm ok to merge this PR 👍 .
There was a problem hiding this comment.
works good in IE 10, 11
oliviertassinari
added a commit
that referenced
this pull request
Jan 3, 2016
[TimePicker] improve am/pm buttons
|
@netoctone Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Here's second part of TimePicker update #2358
Let me know if we need ripple effect on "am"/"pm" switches and/or on "hour"/"minute" mode switches.