Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DateTimePicker] Change bottom position of AM/PM buttons #27534

Merged
merged 7 commits into from
Sep 9, 2021
Merged

[DateTimePicker] Change bottom position of AM/PM buttons #27534

merged 7 commits into from
Sep 9, 2021

Conversation

nikitabobers
Copy link
Contributor

@nikitabobers nikitabobers commented Jul 31, 2021 •
edited by mnajdova
Loading

@nikitabobers nikitabobers changed the title Change bottom position of AM/PM buttons [DateTimePicker] Change bottom position of AM/PM buttons Jul 31, 2021
@mui-pr-bot
Copy link

mui-pr-bot commented Jul 31, 2021 •
edited
Loading

Details of bundle changes (experimental)

Generated by 🚫 dangerJS against e467cc7

@github-actions github-actions bot mentioned this pull request Jul 31, 2021
Closed
mnajdova
mnajdova approved these changes Aug 2, 2021
View reviewed changes
Copy link
Member

@mnajdova mnajdova left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I've added a link to the PR description with the codesandbox showing the fix (it is the same example from the issue, but it's using this PR's packages)

@eps1lon eps1lon added bug 🐛 Something doesn't work component: date time picker This is the name of the generic UI component, not the React module! labels Aug 10, 2021
eps1lon
eps1lon requested changes Aug 10, 2021
View reviewed changes
Copy link
Member

@eps1lon eps1lon left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work.

Unfortunately, this breaks styles of the ClockPicker (which is used by the TimePicker): https://deploy-preview-27534--material-ui.netlify.app/components/time-picker/#basic-usage

Screenshot from 2021-08-10 17-21-10

@nikitabobers
Copy link
Contributor Author

nikitabobers commented Aug 11, 2021 •
edited
Loading

Didn't notice that, sry. I'll try to fix it and apply for DateTimePicker only, where is Cancel/OK buttons

@nikitabobers nikitabobers requested a review from eps1lon August 11, 2021 17:10
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Sep 6, 2021
@eps1lon eps1lon self-assigned this Sep 8, 2021
@eps1lon eps1lon mentioned this pull request Sep 8, 2021
Merged
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Sep 9, 2021
eps1lon
eps1lon approved these changes Sep 9, 2021
View reviewed changes
Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now without breaking the TimePicker

@eps1lon eps1lon merged commit 6628266 into mui:next Sep 9, 2021
@nikitabobers nikitabobers deleted the #25422 branch March 11, 2022 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnajdova mnajdova mnajdova approved these changes

@eps1lon eps1lon eps1lon approved these changes

Assignees

@eps1lon eps1lon

Labels
bug 🐛 Something doesn't work component: date time picker This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DateTimePicker] formatting OK/PM buttons overlap
4 participants
@nikitabobers @mui-pr-bot @mnajdova @eps1lon