v4.12.3 #27465
Merged
v4.12.3 #27465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Details of bundle changes.Comparing: e02afb6...bb19dfa Details of page changes
|
mnajdova
reviewed
Jul 27, 2021
Co-authored-by: Marija Najdova <[email protected]>
mnajdova
approved these changes
Jul 27, 2021
| ### `@material-ui/[email protected]` | ||
|
|
||
| - <!-- 2 --> [AccordionSummary] Fix false-positive propType warning with `disableGeneration` (#27385) @eps1lon | ||
| - <!-- 6 --> [TablePagination] Re-introduce deprecated `onChangePage` to `ActionsComponent` (#27407) @eps1lon |
There was a problem hiding this comment.
The component is the Table?
Suggested change
| - <!-- 6 --> [TablePagination] Re-introduce deprecated `onChangePage` to `ActionsComponent` (#27407) @eps1lon | |
| - <!-- 6 --> [Table] Re-introduce deprecated TablePagination `onChangePage` to `ActionsComponent` (#27407) @eps1lon |
There was a problem hiding this comment.
We changed TablePagination, not Table:
https://github.com/mui-org/material-ui/pull/27407/files
There was a problem hiding this comment.
I had tried to document the standard used so far in https://www.notion.so/material-ui/GitHub-issues-PRs-c1d7072e0c2545b0beb43b115f6030f6
A pull request most often has one primary label. It's defined with the "[XXX] Syntax". XXX must match with existing GitHub labels.
It's arbitrary, I think that what matters is to be consistent. "Table" matches an existing GitHub label.
If we want to change the standard, then it's a different discussion, why not.
I think that we should get it changed at the whole org level, not on an individual basis. It would help external developers read the changelog, the issues, the PRs, contribute.
There was a problem hiding this comment.
We didn't discuss it to begin with so I don't accept that standard. Your approach is not suitable for a changelog which is what we're discussing here.
You already agreed with my approach: The title should match the component. Though you mistook the PR to adress the Table component. However, it did adress the TablePagination component so that's the correct title.
I think that we should get it changed at the whole org level, not on an individual basis.
Agreed. There's no org-level at the moment though.
|
|
||
| ### `@material-ui/[email protected]` | ||
|
|
||
| - <!-- 2 --> [AccordionSummary] Fix false-positive propType warning with `disableGeneration` (#27385) @eps1lon |
There was a problem hiding this comment.
The component is the Accordion?
Suggested change
| - <!-- 2 --> [AccordionSummary] Fix false-positive propType warning with `disableGeneration` (#27385) @eps1lon | |
| - <!-- 2 --> [Accordion] Fix AccordionSummary false-positive propType warning with `disableGeneration` (#27385) @eps1lon |
Co-authored-by: Olivier Tassinari <[email protected]>
siriwatknp
approved these changes
Jul 28, 2021
forgot in previous merge commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.