-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Accordion] Ensure AccordionSummary backwards compatible deprecation of classes.focused #27351
Merged
eps1lon
merged 3 commits into
mui:master
from
eps1lon:fix/Accordion/classes-focused-deprecation
Jul 19, 2021
Merged
[Accordion] Ensure AccordionSummary backwards compatible deprecation of classes.focused #27351
eps1lon
merged 3 commits into
mui:master
from
eps1lon:fix/Accordion/classes-focused-deprecation
Jul 19, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
added
bug 🐛
Something doesn't work
component: accordion
This is the name of the generic UI component, not the React module!
v5.x migration
labels
Jul 19, 2021
Details of bundle changes.Comparing: a74def3...a760a81 Details of page changes
|
mnajdova
reviewed
Jul 19, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could spot only one issue, apart from that looks good. Good catch
Co-authored-by: Marija Najdova <[email protected]>
eps1lon
changed the title
[AccordionSummary] Ensure backwards compatible deprecation
[AccordionSummary] Ensure backwards compatible deprecation of classes.focused
Jul 19, 2021
oliviertassinari
changed the title
[AccordionSummary] Ensure backwards compatible deprecation of classes.focused
[Accordion] Ensure AccordionSummary backwards compatible deprecation of classes.focused
Jul 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug 🐛
Something doesn't work
component: accordion
This is the name of the generic UI component, not the React module!
v5.x migration
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#24083 was not a deprecation but a breaking change. It also moved the deprecation warning to
Accordion
even thoughAccordion
neither hadfocused
nor hasfocusVisible
(was also misspelled asfocusedVisible
). Seems to me the deprecation should be place inAccordionSummary
.Update to migration notes: #27352