[Radio] Fix support for number value type

[sakura90]

• I have followed (at least) the PR section of the contributing guide.

• Modified Radio value to any. Implemented exactly like the Select [Select] Improve the value comparison function #13408. Made areEqualValues as an util function so both Select and Radio can use it.

• Modified RadioGroup defaultValue to any.

• Updated API documentation.

Closes #26333

[mui-pr-bot]

Details of bundle changes

Generated by 🚫 dangerJS against b0a9129

[oliviertassinari]

Could we add a test case too?

[eps1lon]

I don't think we should do this. Comparing arrays by their string value does not make much sense. People should explicitly stringify the value if they wish to.

This becomes especially confusing if the type changes over time

[sakura90]

@eps1lon The PR is a draft PR. It is not ready for being reviewed. Please look at the following link:

https://codesandbox.io/s/create-react-app-with-typescript-forked-qlk19?file=/src/App.tsx

After a user clicks Option a1b3, the radio button is not checked, but it should be. I have to fix itn before letting you review it.

I don't think we should do this. Comparing arrays by their string value does not make much sense. People should explicitly stringify the value if they wish to.
This becomes especially confusing if the type changes over time

Please let me comment on it after I fix the above problem. It is not about Material-UI but JavaScript. typeof Array is object, so comparing arrays by their string value is not going to be ther.

[oliviertassinari]

I have pushed a new commit with a test case, only to support data structures with a decent .toString(), most notably numbers.

I wasn't too sure if we needed to support rich data structure as object or array:

• Pros: More flexibility for the developers, allow to be quick and dirty 👌
• Cons: The value can't be sent to a form with POST (who does this anyway, 5% of the audience?)

#26333 was about numbers, so maybe we can defer this "object" aspect.

[siriwatknp]

#26333 was about numbers, so maybe we can defer this "object" aspect.

Totally agree, string | number is enough.

[sakura90]

@siriwatknp @oliviertassinari Look to me the PR can be closed. I was thinking about supporting any for Radio value. @siriwatknp helped change support to number/string. Support to number/string is enough to resolve #26333, and so I think the change was ok. @oliviertassinari helped add a test case and reorganized the utility function areEqualValues, and I think the PR became better for resolving #26333. The PR currently is in the opne state but it can be closed. There is a button 'Close with comment'. Please let me try to use the button to close it.

[oliviertassinari]

We were really close, I'm reopening

[sakura90]

@oliviertassinari could you tell me what else needs to be done? Not following the PR for a while, so not sure what is going on.

[oliviertassinari]

@sakura90 We only need a rebase, done :)

[oliviertassinari]

@eps1lon Is #26772 (review) still up to date? The PR now focuses on fixing the support for number values. It works more closely to a native input type="checkbox". What use case did you have in mind with the array?

[Krasnopir]

Sorry. But if use Radio with FormControlLabel in RadioGroup - problem remained.
I can set for Radio value as number, but when change, in form state it transform to string.