-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "[icons] Only ship ES modules (#26310)" #26656
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a6f79d4.
eps1lon
force-pushed
the
fix/revert-es-modules
branch
from
June 8, 2021 20:51
b9944a5
to
8d1b146
Compare
I don't think it's just nextjs. I have a trying to migrate a project to latest material ui with
and I got following error in jest of create-react-app. It really weird. app is working fine in browser. Not sure if I am missing anything here.
However codesandbox works with exact same case |
2 tasks
This was referenced Jun 10, 2021
This also breaks our webpack 5 build:
|
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #26310 (comment) until we can fix nextjs integration.
Our test fixtures weren't set up properly and I'm not sure why our usage is working.