Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TimePicker] Fire change event when meridiem changes (#26600) #26600

Merged
merged 5 commits into from
Sep 21, 2021
Merged

[TimePicker] Fire change event when meridiem changes (#26600) #26600

merged 5 commits into from
Sep 21, 2021

Conversation

DrPuneetGaur
Copy link
Contributor

@DrPuneetGaur DrPuneetGaur commented Jun 5, 2021 •
edited by oliviertassinari
Loading

@mui-pr-bot
Copy link

mui-pr-bot commented Jun 5, 2021 •
edited
Loading

Details of bundle changes

Generated by 🚫 dangerJS against d2fa1ee

@DrPuneetGaur

This comment has been minimized.

Sign in to view
@oliviertassinari oliviertassinari changed the title [Timepicker] Pass partial as selection state in handleMeridiemChange … [TimePicker] Fix meridiem change not fixing onChange Jun 5, 2021
@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work component: timeline This is the name of the generic UI component, not the React module! labels Jun 5, 2021
@oliviertassinari oliviertassinari force-pushed the trigger-on-change-event-on-ampm-change-timepicker-component branch 6 times, most recently from 7f31a2b to 3a0823d Compare June 5, 2021 17:54
@oliviertassinari oliviertassinari force-pushed the trigger-on-change-event-on-ampm-change-timepicker-component branch from 3a0823d to 1fef982 Compare June 5, 2021 18:10
@oliviertassinari oliviertassinari force-pushed the trigger-on-change-event-on-ampm-change-timepicker-component branch from 1fef982 to fbf529b Compare June 5, 2021 18:14
@oliviertassinari oliviertassinari requested a review from eps1lon June 5, 2021 18:16
eps1lon
eps1lon requested changes Jun 7, 2021
View reviewed changes
Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oliviertassinari What are all these changes about you pushed? The author of this PR clearly did not intend these changes. Please extract them into a separate PR so that we can understand later what this PR was about.

@oliviertassinari
Copy link
Member

oliviertassinari commented Jun 7, 2021 •
edited
Loading

so that we can understand later what this PR was about

@eps1lon We can find the initial change of the author in the first commit: bffb87f, it fixes the bug. My commit (fbf529b) does:

  • Add a failing test case for the bug
  • Improve the Meridiem type
  • Remove useless abstraction (useMeridiemMode)
  • Remove useless Typography meridiem component

My intent was to polish things that I could see closely related to the AM/PM UI (it's still below ±100 LOCs for instance).

@eps1lon
Copy link
Member

eps1lon commented Jun 7, 2021

Improve the Meridiem type
Remove useless abstraction (useMeridiemMode)
Remove useless Typography meridiem component

I disagree with all of these points.

@Sandeep06Dev
Copy link
Contributor

@eps1lon and @oliviertassinari I think this PR will be resolve my issues #26531 Right ?

@oliviertassinari
Copy link
Member

I disagree with all of these points

@eps1lon OK, I will isolate them into multiple PRs then, once I find the time. Feel free to revert what you don't link in the meantime.

@oliviertassinari oliviertassinari deleted the branch mui:master June 22, 2021 00:28
@oliviertassinari oliviertassinari changed the base branch from foo to next June 22, 2021 00:47
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jul 9, 2021
@eps1lon eps1lon changed the base branch from next to master September 14, 2021 09:28
@eps1lon eps1lon self-assigned this Sep 14, 2021
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Sep 21, 2021
@eps1lon eps1lon assigned eps1lon and unassigned eps1lon Sep 21, 2021
@eps1lon eps1lon changed the title [TimePicker] Fix meridiem change not fixing onChange [TimePicker] Fire change event when meridiem changes Sep 21, 2021
eps1lon
eps1lon approved these changes Sep 21, 2021
View reviewed changes
Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much appreciated, thanks!

@eps1lon eps1lon changed the title [TimePicker] Fire change event when meridiem changes [TimePicker] Fire change event when meridiem changes (#26600) Sep 21, 2021
@eps1lon eps1lon merged commit 58e7ad2 into mui:master Sep 21, 2021
@eps1lon eps1lon mentioned this pull request Oct 2, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

@eps1lon eps1lon eps1lon approved these changes

Assignees

@eps1lon eps1lon

Labels
bug 🐛 Something doesn't work component: timeline This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TimePicker] Switching am pm does not change the time
5 participants
@DrPuneetGaur @mui-pr-bot @oliviertassinari @eps1lon @Sandeep06Dev