Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Grid] Add rowSpacing and columnSpacing props #26559

Merged
merged 4 commits into from
Jun 7, 2021
Merged

[Grid] Add rowSpacing and columnSpacing props #26559

merged 4 commits into from
Jun 7, 2021

Conversation

likitarai1
Copy link
Contributor

@likitarai1 likitarai1 commented Jun 2, 2021 •
edited by oliviertassinari
Loading

Fixes #11764
The aim of this PR is to have separate row and column spacing for grid component.

Preview:

@mui-pr-bot
Copy link

mui-pr-bot commented Jun 2, 2021 •
edited
Loading

Details of bundle changes (experimental)

@material-ui/core: parsed: +0.07% , gzip: +0.03%
@material-ui/lab: parsed: +0.08% , gzip: +0.06%

Generated by 🚫 dangerJS against d2339a7

@github-actions github-actions bot mentioned this pull request Jun 2, 2021
Closed
@oliviertassinari oliviertassinari added the component: Grid The React component. label Jun 2, 2021
@oliviertassinari oliviertassinari changed the title Allow row and column spacing for grid separately [Grid] Add rowSpacing and columnSpacing props Jun 2, 2021
@oliviertassinari oliviertassinari added the new feature New feature or request label Jun 2, 2021
@oliviertassinari oliviertassinari force-pushed the grid-separate-row-col-spacing branch from 8bd8e4e to 6b9d31c Compare June 6, 2021 11:14
oliviertassinari
oliviertassinari approved these changes Jun 6, 2021
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have pushed new changes to:

  • Add visual test case
  • Add docs
  • Add types
  • Polish the CSS grid documentation, e.g. prepare the future live demos with the inline preview.

siriwatknp
siriwatknp approved these changes Jun 6, 2021
View reviewed changes
Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@oliviertassinari

This comment has been minimized.

Sign in to view
@eps1lon

This comment has been minimized.

Sign in to view
@oliviertassinari

This comment has been minimized.

Sign in to view
@eps1lon eps1lon merged commit f7b692e into mui:next Jun 7, 2021
@likitarai1 likitarai1 deleted the grid-separate-row-col-spacing branch June 7, 2021 12:41
@oliviertassinari oliviertassinari mentioned this pull request Jun 7, 2021
Merged
@siriwatknp siriwatknp mentioned this pull request Jun 8, 2021
Merged
1 task
@QueenChristina QueenChristina mentioned this pull request Jul 26, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

@siriwatknp siriwatknp siriwatknp approved these changes

Assignees
No one assigned
Labels
component: Grid The React component. new feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Grid] Allow different values for x and y spacing
5 participants
@likitarai1 @mui-pr-bot @oliviertassinari @eps1lon @siriwatknp