[theme] Deprecate createMuiTheme
#26004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@material-ui/core: parsed: +Infinity% , gzip: +Infinity% Details of bundle changes.Comparing: f731e9d...4d6d387 Details of page changes
|
1 task
oliviertassinari
approved these changes
Apr 29, 2021
|
It seems like you haven't deprecated but removed |
|
@Guneetgstar If you were using a private import: import createMuiTheme from "@material-ui/core/styles/createMuiTheme";Now, you know it was private. We cover it a bit in https://material-ui.com/guides/minimizing-bundle-size/#option-1. We don't follow semver for private APIs. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Yeah, thats the issue. Thanks for the link. |
It's private. You can't access it. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
onpaws
added a commit
to splitgraph/splitgraph.com
that referenced
this pull request
Aug 4, 2021
onpaws
added a commit
to splitgraph/splitgraph.com
that referenced
this pull request
Aug 4, 2021
onpaws
added a commit
to splitgraph/splitgraph.com
that referenced
this pull request
Aug 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add deprecation for #25992.