[test] Use public api in lab #25682
Merged
[test] Use public api in lab #25682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
vicasas
changed the title
|
Should we do the same in the core? |
mnajdova
changed the title
Yes, ideally we would use the public API for the test inside the core as well. Although would propose doing it in separate PR. |
mnajdova
approved these changes
Apr 9, 2021
|
@mnajdova Well, I'll be working on that during the day. |
| @@ -1,2 +1,5 @@ | |||
| export { default } from './TabPanel'; | |||
| export * from './TabPanel'; | |||
|
|
|||
| export { default as tabPanelClasses } from './tabPanelClasses'; | |||
|
For the files Example: - import { PaperProps } from '../Paper';
+ import { PaperProps } from '@material-ui/core/Paper';and - import { Theme } from '..'
+ import { Theme } from '@material-ui/core/styles'? |
|
@vicasas only if the import is coming from another package. |
oliviertassinari
approved these changes
Apr 9, 2021
|
Merging this one, so that next PRs can reference the correct imports |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corresponds to comment #25666 and comment #25666