[Autocomplete] Fix text field standard visual regression #25676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
bug 🐛
Oh well, we have no visual regression coverage. I guess it's why we introduced the regression in the first place. Should we add one? |
Please 😊 |
This comment has been minimized.
This comment has been minimized.
|
Visual regression test added, ready for review |
eps1lon
approved these changes
Apr 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have noticed the issue looking into #25657.
v4 (OK):
https://material-ui.com/components/autocomplete/#playground
HEAD (KO):
https://next.material-ui.com/components/autocomplete/#playground
The visual regression should confirm the fix work (bring us back to v4). Regarding why the regression has happened. It's related to a recent change of the
<input>line-heightin the InputBase component to account for fonts with long descended and ascender characters. It's not related to emotion.