Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[styles] Outdated warning message #25637

Merged
merged 2 commits into from
Apr 7, 2021
Merged

[styles] Outdated warning message #25637

merged 2 commits into from
Apr 7, 2021

Conversation

bhairavee23
Copy link
Contributor

@bhairavee23 bhairavee23 commented Apr 6, 2021 •
edited by oliviertassinari
Loading

Closes #25559

@bhairavee23 bhairavee23 mentioned this pull request Apr 6, 2021
Closed
2 tasks
@mui-pr-bot
Copy link

mui-pr-bot commented Apr 6, 2021 •
edited
Loading

No bundle size changes

Generated by 🚫 dangerJS against 76ede1a

@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation package: styles Specific to @mui/styles. Legacy package, @material-ui/styled-engine is taking over in v5. labels Apr 6, 2021
@eps1lon
Copy link
Member

eps1lon commented Apr 6, 2021

@oliviertassinari How is this code used internally i.e. can we add a test case? It's not clear whether this is relevant to old or new styling engine.

oliviertassinari
oliviertassinari approved these changes Apr 6, 2021
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eps1lon It's legacy at this point (old). I have proposed that we fix it to reduce confusion during the migration period of v5, for the one year or two to come.

Should we add a test case? I personally fail to see the long term value for this area of the codebase but if the author can provide it, it would be better

@bhairavee23
Copy link
Contributor Author

bhairavee23 commented Apr 6, 2021 •
edited
Loading

so can this be merged? thanks for the approval @oliviertassinari

@oliviertassinari
Copy link
Member

@bhairavee23 Could you look into adding a test case? :)

oliviertassinari
oliviertassinari approved these changes Apr 6, 2021
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added a test case.

@mnajdova At first, I thought that we could add this warning back into the new solution. But looking closer at the implementation, it doesn't seem possible because of the dynamic props.

@eps1lon eps1lon merged commit d520cfc into mui:next Apr 7, 2021
@eps1lon
Copy link
Member

eps1lon commented Apr 7, 2021

@bhairavee23 Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation package: styles Specific to @mui/styles. Legacy package, @material-ui/styled-engine is taking over in v5.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[styles] Outdated warning message
4 participants
@bhairavee23 @mui-pr-bot @eps1lon @oliviertassinari