Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Use env next config over DefinePlugin #25373

Merged
merged 4 commits into from
Mar 16, 2021
Merged

[docs] Use env next config over DefinePlugin #25373

merged 4 commits into from
Mar 16, 2021

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Mar 15, 2021

In next 10 webpack is bundled so resolutions does not have any effect. This can result in a mismatch between webpack.DefinePlugin and the webpack version used by next. We can use their 1st class API for environment variables instead.

@eps1lon eps1lon added the docs Improvements or additions to the documentation label Mar 15, 2021
@mui-pr-bot
Copy link

mui-pr-bot commented Mar 15, 2021 •
edited
Loading

No bundle size changes

Generated by 🚫 dangerJS against 715415e

@github-actions github-actions bot mentioned this pull request Mar 15, 2021
Closed
@eps1lon eps1lon marked this pull request as ready for review March 15, 2021 17:04
@eps1lon eps1lon merged commit c3a1af1 into mui:next Mar 16, 2021
@eps1lon eps1lon deleted the docs/env-define branch March 16, 2021 08:15
@oliviertassinari oliviertassinari mentioned this pull request Mar 28, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eps1lon @mui-pr-bot