[pickers] Simplify internals of *Wrapper components #25369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
added
the
component: pickers
eps1lon
commented
Mar 15, 2021
| @@ -33,7 +33,6 @@ export interface PrivateWrapperProps { | |||
| PureDateInputComponent?: React.ComponentType<DateInputPropsLike>; | |||
| } | |||
|
|
|||
| /** Root interface for all wrappers props. Any wrapper can accept all the props and must spread them. */ | |||
There was a problem hiding this comment.
I don't understand why we would want this. The only use case are responsive pickers that should accept props for mobile and desktop. But e.g. mobile wrappers accepting desktop props does not make sense.
|
@material-ui/lab: parsed: -1.86% 😍, gzip: -0.52% 😍 |
eps1lon
force-pushed
the
chore/pickers/wrapper-simpl
branch
from
5d422fb to
9893465
Compare
We can just pass the props directly and don't need to extract them from the component.
eps1lon
force-pushed
the
chore/pickers/wrapper-simpl
branch
from
9893465 to
83223c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out we don't need these concrete wrapper components (e.g.
DesktopTimePickerWrapper).Once we inlined
makeDateRangePickerwe can reduce the rest of the wrapper utility types.