[ButtonBase] Allow to customize the link component via theme

[vedadeepta]

Fixes: #21533

• I have followed (at least) the PR section of the contributing guide.

[mui-pr-bot]

Details of bundle changes

Generated by 🚫 dangerJS against de527e2

[oliviertassinari]

Why did you modify the source of the Button? (Why is ButtonBase not enough?)

[vedadeepta]

You're right, Button modification is not needed. I will make changes

[vedadeepta]

@oliviertassinari

Well, now that I think about it modifying Button is necessary to support this kind of theme config as discussed in the issue

const theme = createMuiTheme({
  props: {
    MuiLink: {
      component: RouterLink, 
    },
    MuiButton: {
     link: RouterLink, // 👈 explicit option for "links-as-buttons" 
    }
  },
});

Since we want the link option to be inside MuiButton not inside MuiButtonBase.

[oliviertassinari]

Since we want the link option to be inside MuiButton not inside MuiButtonBase.

Why? This sounds counter-intuitive to me. Isn't the objective to replace all the links?

[vedadeepta]

No particular reason, I was following this
comment in the issue, seems like its how they want it. But I can change the API such that link is is inside MuiButtonBase of the theme if you think that makes more sense. I don't have strong preference either way.

objective to replace all the links?

Both ways accomplishes this objective. Right? There is a single place to configure the Link component used by buttons.

[oliviertassinari]

@vedadeepta Yes, I think that we should ignore Button because it's only one of the wrappers built on top of ButtonBase. It's only relevant as a use case. Props are also spreading so, whatever ButtonBase supports, Button does to.

[vedadeepta]

makes sense, will fix it tomorrow.

[oliviertassinari]

I have tried to improve the docs by creating a new section only for Routing. It seems to be a common pain point.
https://deploy-preview-25331--material-ui.netlify.app/guides/routing/

[vedadeepta]

any update on this PR?

[oliviertassinari]

@vedadeepta I wanted to make a small change to the markdown before merging. To expose the theme structure without requiring developers to click anything.

[vedadeepta]

aight, makes sense

[oliviertassinari]

@vedadeepta Done, thanks for dedicating care and time to this :)

[vedadeepta]

thanks for reviewing & improving the PR, appreciated.