Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Autocomplete] Fix styleOverrides support #25276

Merged
merged 2 commits into from
Mar 9, 2021
Merged

[Autocomplete] Fix styleOverrides support #25276

merged 2 commits into from
Mar 9, 2021

Conversation

manziEric
Copy link
Contributor

@manziEric manziEric commented Mar 9, 2021 •
edited by oliviertassinari
Loading

Fix #25147

@mui-pr-bot
Copy link

mui-pr-bot commented Mar 9, 2021 •
edited
Loading

Details of bundle changes

Generated by 🚫 dangerJS against d8321e2

@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work component: autocomplete This is the name of the generic UI component, not the React module! labels Mar 9, 2021
@oliviertassinari oliviertassinari changed the title fix: update Autocomplete styleOverrides not apply working for Paper [Autocomplete] Fix styleOverrides support Mar 9, 2021
@manziEric
Copy link
Contributor Author

manziEric commented Mar 9, 2021 •
edited by oliviertassinari
Loading

@oliviertassinari Any idea how I can fix this test_browser-1 error?

@oliviertassinari
Copy link
Member

oliviertassinari commented Mar 9, 2021 •
edited
Loading

any idea how i can fix this test_browser-1 error?

@manziEric It was a flakiness issue with the CI. I have rerun it, it was green after.

Now, I have also added a regression test for this change. This test isn't perfect nor testing everything but it improves the coverage a bit. This component is more complex than the others, the portal and the nested child means that describeConformance isn't enough.

@manziEric
Copy link
Contributor Author

@oliviertassinari thanks for the explanation

@oliviertassinari oliviertassinari merged commit 9a33e92 into mui:next Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: autocomplete This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Autocomplete] styleOverrides not apply working for Paper
3 participants
@manziEric @mui-pr-bot @oliviertassinari