Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SwipeableDrawer] Fix hideBackDrop support #25275

Merged
merged 4 commits into from
Mar 9, 2021
Merged

[SwipeableDrawer] Fix hideBackDrop support #25275

merged 4 commits into from
Mar 9, 2021

Conversation

manziEric
Copy link
Contributor

close: #25168

@mui-pr-bot
Copy link

mui-pr-bot commented Mar 9, 2021 •
edited
Loading

Details of bundle changes

Generated by 🚫 dangerJS against 5625909

@oliviertassinari oliviertassinari changed the title fix: update hideBackDrop in SwipeableDrawer.js [SwipeableDrawer] Fix hideBackDrop support Mar 9, 2021
@oliviertassinari oliviertassinari added component: SwipeableDrawer The React component. bug 🐛 Something doesn't work labels Mar 9, 2021
@manziEric
Copy link
Contributor Author

@oliviertassinari i did yarn test:karma on local copy i get this error: React does not recognize the hideBackdrop prop on a DOM element. If you intentionally want it to appear in the DOM as a custom attribute, spell it as lowercase hidebackdrop instead.

@oliviertassinari
Copy link
Member

@manziEric The existing tests were useless. I have updated them so we can avoid this double regression going forward.

@github-actions github-actions bot mentioned this pull request Mar 9, 2021
Closed
@oliviertassinari oliviertassinari merged commit 375e0c8 into mui:next Mar 9, 2021
@oliviertassinari oliviertassinari added the component: drawer This is the name of the generic UI component, not the React module! label Nov 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: drawer This is the name of the generic UI component, not the React module! component: SwipeableDrawer The React component.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[SwipeableDrawer] hideBackDrop raise TypeError
3 participants
@manziEric @mui-pr-bot @oliviertassinari