Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Add missing props to *DatePicker API #25254

Merged
merged 3 commits into from
Mar 8, 2021
Merged

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Mar 7, 2021

yarn proptypes is incomplete if files are used that can't be parsed by TypeScript 3.5. import type is one of those things.

I haven't figured out how to throw if these diagnostics affect yarn proptypes so for now we have to do it manually (as documented in code).

We could lint against it with no-restricted-syntax and ImportDeclaration[importKind="type"] but eslint rules can only be overridden not extended and I don't want to spend an hour digging through all the configs we have to find out what we currently lint against.

@eps1lon eps1lon added the docs Improvements or additions to the documentation label Mar 7, 2021
scripts/generateProptypes.ts Outdated Show resolved Hide resolved
@mui-pr-bot
Copy link

mui-pr-bot commented Mar 7, 2021

No bundle size changes

Generated by 🚫 dangerJS against 6eb2b86

@eps1lon eps1lon marked this pull request as ready for review March 7, 2021 17:59
@eps1lon eps1lon added the on hold There is a blocker, we need to wait label Mar 8, 2021
@eps1lon eps1lon removed the on hold There is a blocker, we need to wait label Mar 8, 2021
@eps1lon eps1lon merged commit f1bcacd into mui:next Mar 8, 2021
@eps1lon eps1lon deleted the docs/ttp-cleanup branch March 8, 2021 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants