-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Transition] Add easing prop to override default timing function #25245
[Transition] Add easing prop to override default timing function #25245
Conversation
@material-ui/lab: parsed: +0.09% , gzip: +0.06% |
deafa05
to
fb13a5c
Compare
c26daa3
to
31db850
Compare
I have updated the pull request to remove the change of default transitions. See https://material.io/design/motion/speed.html#easing for why the new defaults seem to be not be correct. I think that It's also outside of the scope of the problem we are trying to solve. |
@oliviertassinari oh I didn't know that, thanks for the updates :) |
I have added one test case to have a minimum of coverage on the approach. Looking at how we test the transition helpers, something feels slitly wrong. We should probably abstract the tests as we do in |
I have followed (at least) the PR section of the contributing guide.
Add easing (transition timing function) property to transition components to be able override the default style on enter and leave animations, similar to how timeout is set up.
Fix #24980