Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Table] Use primary cover over secondary for selected state #25182

Merged
merged 4 commits into from
Mar 4, 2021
Merged

[Table] Use primary cover over secondary for selected state #25182

merged 4 commits into from
Mar 4, 2021

Conversation

beaudry
Copy link
Contributor

@beaudry beaudry commented Mar 3, 2021 •
edited
Loading

Fix #25176

@mui-pr-bot
Copy link

mui-pr-bot commented Mar 3, 2021 •
edited
Loading

Details of bundle changes

Generated by 🚫 dangerJS against c149271

@oliviertassinari oliviertassinari changed the title [TableRow] Change selected color [Table] Use primary cover over secondary for selected state Mar 3, 2021
@oliviertassinari oliviertassinari added breaking change component: table This is the name of the generic UI component, not the React module! design: material This is about Material Design, please involve a visual or UX designer in the process labels Mar 3, 2021
oliviertassinari
oliviertassinari requested changes Mar 3, 2021
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for having a try at it. However, we also need to update the demos, it's not currently consistent.

Screenshot 2021-03-04 at 00 27 36

https://deploy-preview-25182--material-ui.netlify.app/components/tables/#sorting-amp-selecting

@beaudry
Copy link
Contributor Author

beaudry commented Mar 3, 2021

I'm on it!

@beaudry
Copy link
Contributor Author

beaudry commented Mar 4, 2021 •
edited
Loading

Done! :)

image
image

The width of the doc is different when you switch from light to dark. Dark is wider. Is that a known issue? It's only on next.

@beaudry beaudry requested a review from oliviertassinari March 4, 2021 16:10
@beaudry
Copy link
Contributor Author

beaudry commented Mar 4, 2021

The demos update themselves on CodeSandbox? 😮 That's awesome! 😃

@beaudry
Copy link
Contributor Author

beaudry commented Mar 4, 2021

Should I open an issue about the width of the docs, depending on the light/dark theme?

@oliviertassinari
Copy link
Member

Should I open an issue about the width of the docs, depending on the light/dark theme?

It was first reported by @eps1lon in #24970.

The demos update themselves on CodeSandbox? 😮 That's awesome! 😃

Yeap, quite useful for us for reviews.

@oliviertassinari oliviertassinari merged commit 7855f2b into mui:next Mar 4, 2021
@oliviertassinari
Copy link
Member

@beaudry Thanks!

@beaudry
Copy link
Contributor Author

beaudry commented Mar 4, 2021

Merci beaucoup @oliviertassinari, nous apprécions ton bon travail! 🙂

Salutations du Québec 👋

@beaudry beaudry deleted the patch-1 branch March 4, 2021 17:59
@github-actions github-actions bot mentioned this pull request Mar 4, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
breaking change component: table This is the name of the generic UI component, not the React module! design: material This is about Material Design, please involve a visual or UX designer in the process
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Table] Row selected color should be primary, not secondary
3 participants
@beaudry @mui-pr-bot @oliviertassinari