[Doc] Improve codgen #2438
Merged
[Doc] Improve codgen #2438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@subjectix Could you have a look? |
|
@oliviertassinari Expanding is done instantly, It scares me 😱 Can it be animated? |
Would be better indeed, let me fix this. |
|
@oliviertassinari Thanks a lot 👍 👍 |
|
@subjectix Transition added https://github.com/callemall/material-ui/pull/2438/files#diff-97439f8083792f35079c7682f86df377R18 |
|
Why? It's not fully expanded |
|
Alright, I have increased the max height from 1000px to 2000px. |
|
@oliviertassinari Awesome 👍 👍 Thanks 🎉 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce an expand/retract button for code example.
This is useful for long examples as we have on the
Toolbarspage.I have also rename some page to stay coherent.