[core] Support public paths in module augmentation #24267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
approved these changes
Jan 4, 2021
Comment on lines
+37
to
+39
| await Promise.all( | ||
| tsconfigPaths.map(async (tsconfigPath) => { | ||
| await test(tsconfigPath).then( |
There was a problem hiding this comment.
I wonder if running one process per test case in concurrence will scale well with the number of test cases. I don't know how TypeScript handles the requests internally. I don't think the scaling question is something we need to worry too much about now, as we don't yet have a large number of test cases. I was curious.
There was a problem hiding this comment.
Yeah, I haven't looked into the issue too much. There's a lot of wasted work by doing a full compilation just to test module augmentation. test_types isn't really a bottleneck at the moment but once it becomes one we might want to look into the issue a bit more. Right now I'm glad we have some tests for module augmentation in place.
eps1lon
changed the title
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a notion of what we consider "public paths". However, this does not apply to type imports which makes it harder to teach ("ok here, but not ok there"). Since we already make types public by documenting that the paths are public we might as well export them directly which means we can simplify how we teach public paths.
The existing patterns continue to work but are more likely to break during refactoring. The patterns we now document are tested in CI and therefore a lot more robust.
Implementation choices
separate script
test:unitmocha)