[Doc] Slightly improved propsTable layout #2425 #2426
Conversation
|
@frankf-cgn This looks good. thank you. Only one issue, please make deafults more contrast, it's a bit hard to read |
| @@ -51,7 +53,9 @@ const PropTypeDescription = React.createClass({ | |||
| } | |||
|
|
|||
| return ( | |||
| <MarkdownElement text={text} /> | |||
| <div className={'propsTable'}> | |||
There was a problem hiding this comment.
Wouldn't className="propsTable" be better?
|
Awesome 👍 👍 Please do a rebase and we'll merge this. |
|
@oliviertassinari Let me rebase if you are ok with the code. |
| @@ -51,7 +53,9 @@ const PropTypeDescription = React.createClass({ | |||
| } | |||
|
|
|||
| return ( | |||
| <MarkdownElement text={text} /> | |||
| <div className="propsTable"> | |||
There was a problem hiding this comment.
I'm gonna be rude, but I think that PropTypeDescription or in lower case would be a more explicit className. Though ?
There was a problem hiding this comment.
I'm gonna do it, but I think that way too verbose. propTypeTable maybe? But one is good as another, I think ;-)
There was a problem hiding this comment.
I think propsTable is the balance between verbosity and explicitness. 👍 for propsTable 😁
There was a problem hiding this comment.
Then we should rename the component to PropsTable?
There was a problem hiding this comment.
I don't think so, let me rename the className, ok?
There was a problem hiding this comment.
@oliviertassinari 😱 I see your point. PropTypeDescription 👍
frankf-cgn
force-pushed
the
issues/2425
branch
from
2ee5a6b to
3423184
Compare
|
Fixed the classname and rebased. |
|
@frankf-cgn Thanks. Should we rename |
frankf-cgn
force-pushed
the
issues/2425
branch
from
3423184 to
bbc0d30
Compare
|
@oliviertassinari You are right. Done. |
|
@frankf-cgn Awesome, thanks! |
[Doc] Slightly improved propsTable layout #2425
|
@frankf-cgn The props look awesome thanks a bunch 👍 🎉 |
zannager
added
docs
Because styling a table in markdown is not directly supported, I have reverted to a pure css solution and wrapped the
<MarkdownElement>in<PropTypeDescription>with a div.Fix #2425