[test] Deprecate test-utils #24099
Merged
[test] Deprecate test-utils #24099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@material-ui/core: parsed: +Infinity% , gzip: +Infinity% Details of bundle changes.Comparing: dc4cf94...d9ff0f7 Details of page changes
|
eps1lon
commented
Dec 22, 2020
Comment on lines
+24
to
+35
| before(() => { | ||
| // Trigger deprecation warning. | ||
| try { | ||
| stub(console, 'warn'); | ||
| findOutermostIntrinsic(); | ||
| } catch (error) { | ||
| // ignore | ||
| } finally { | ||
| console.warn.restore(); | ||
| } | ||
| }); | ||
|
|
There was a problem hiding this comment.
Ultimately we'd like to reset modules between each test so that we could test this properly. But we don't have any such API (like jest.resetModules). Though we might want to add per-module methods that manually take care of this and which we strip from the published code. Just typing this out loud for future reference. Right now I don't think it's worth it.
oliviertassinari
approved these changes
Dec 22, 2020
oliviertassinari
pushed a commit
that referenced
this pull request
Jan 24, 2021
oliviertassinari
pushed a commit
that referenced
this pull request
Jan 25, 2021
42 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add deprecations for #21855.
Closes #24074 to prevent diverging branches even further.
git cherry-pick 44db8eee444191ec19caf130d5a0e4b0bdf1755a -X ours/core/test-utils