Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SelectField] Propagate underline styles #2405

Merged
merged 1 commit into from
Dec 7, 2015
Merged

[SelectField] Propagate underline styles #2405

merged 1 commit into from
Dec 7, 2015

Conversation

alitaheri
Copy link
Member

propagate underlineDisabledStyle, underlineFocusStyle and underlineStyle to the underlying TextField.
@oliviertassinari Please review.

@oliviertassinari
Copy link
Member

Looks good.
I think that we should use the jsx syntax for properties instead of the {...foo} at some point.
(https://github.com/callemall/material-ui/pull/2405/files#diff-a66a0f83cf2d50f9d7d4be309c3d1811R185)

@alitaheri
Copy link
Member Author

@oliviertassinari I agree. We should also do something about other anti-patterns like value-link too. for now I'll just merge this.

alitaheri added a commit that referenced this pull request Dec 7, 2015
@alitaheri
Merge pull request #2405 from subjectix/seleft-field-propagate-underl…
3a11da2 
…ine-styles

[SelectField] Propagate underline styles
@alitaheri alitaheri merged commit 3a11da2 into mui:master Dec 7, 2015
@alitaheri alitaheri deleted the seleft-field-propagate-underline-styles branch December 7, 2015 09:36
@alitaheri alitaheri mentioned this pull request Dec 7, 2015
Closed
@zannager zannager added component: select This is the name of the generic UI component, not the React module! package: styles Specific to @mui/styles. Legacy package, @material-ui/styled-engine is taking over in v5. labels Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
component: select This is the name of the generic UI component, not the React module! package: styles Specific to @mui/styles. Legacy package, @material-ui/styled-engine is taking over in v5.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alitaheri @oliviertassinari @zannager