-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Select] Fixing typescript not recognizing the 'component' property on the 'MenuListProps' #23876
[Select] Fixing typescript not recognizing the 'component' property on the 'MenuListProps' #23876
Conversation
@domodevelopment Did you have progress with this problem? |
@oliviertassinari I haven't been able to make more progress since last weekend, but today I'll get the tests passing and move this out of draft |
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/mui-org/material-ui/4nn1faq9p |
Hmm. @oliviertassinari if there's a chance you can help me with what's going on in
I'm having some difficulty understanding why that might be the case or what my changes would've caused for it to get removed. Any thoughts? |
@domodevelopment I barely know this part of the codebase. @eps1lon Is more familiar with it. |
I'm closing as the effort has been stale for some time, thanks for the exploration. |
(This builds off of discussion in #17646)
Fixes #17579.
These changes try and follow a similar pattern for the
CardHeader
in #20179. Guidance on how I should write more robust tests for this would be appreciated as well as if this is even going in the right direction in the first place :-)