Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[system] Make borderRadius multiply a theme's design token #23700

Merged
merged 13 commits into from
Nov 25, 2020
Merged

[system] Make borderRadius multiply a theme's design token #23700

merged 13 commits into from
Nov 25, 2020

Conversation

mnajdova
Copy link
Member

@mnajdova mnajdova commented Nov 24, 2020 •
edited by oliviertassinari
Loading

Breaking changes

  • [system] The borderRadius system prop value transformation has been changed. It now expects number and multiplies this value with the theme.shape.borderRadius value.

    -<Box sx={{ borderRadius: 'borderRadius' }}>
+<Box sx={{ borderRadius: 1 }}> // theme.shape.borderRadius * 1
    -<Box sx={{ borderRadius: 16 }}>
+<Box sx={{ borderRadius: '16px' }}>

Closes #23188

@mui-pr-bot
Copy link

mui-pr-bot commented Nov 24, 2020 •
edited
Loading

@material-ui/core: parsed: +0.06% , gzip: +0.11%
@material-ui/system: parsed: +3.04% , gzip: +2.29%

Details of bundle changes

Generated by 🚫 dangerJS against 96b67d1

@mnajdova mnajdova added breaking change package: system Specific to @mui/system labels Nov 24, 2020
@oliviertassinari oliviertassinari changed the title [system] Change the borderRadius prop to use the theme.shape.borderRadius as a multiplication value [system] Change borderRadius to multiple the unit from the theme Nov 24, 2020
@oliviertassinari oliviertassinari changed the title [system] Change borderRadius to multiple the unit from the theme [system] Make borderRadius multiply a theme's design token Nov 24, 2020
mbrookes
mbrookes previously requested changes Nov 24, 2020
View reviewed changes
docs/src/pages/guides/migration-v4/migration-v4.md Outdated Show resolved Hide resolved
packages/material-ui-system/src/borders.js Outdated Show resolved Hide resolved
@mnajdova mnajdova requested a review from mbrookes November 25, 2020 09:49
@mnajdova mnajdova merged commit 161fb85 into mui:next Nov 25, 2020
@oliviertassinari oliviertassinari added this to the v5-beta milestone Aug 17, 2021
@oliviertassinari oliviertassinari mentioned this pull request Aug 17, 2021
Closed
42 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbrookes mbrookes mbrookes approved these changes

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
breaking change package: system Specific to @mui/system
Projects
None yet
Milestone
v5-beta
Development

Successfully merging this pull request may close these issues.

[system] Change the borderRadius prop to use the theme.shape.borderRadius as a multiplication value
4 participants
@mnajdova @mui-pr-bot @mbrookes @oliviertassinari