Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds componentWillReceiveProps to Toggle component #237

Merged
merged 1 commit into from
Jan 13, 2015

Conversation

seanders
Copy link
Contributor

Fixes #236. Simply adds componentWillReceiveProps so we can pass props to the state for a Toggle component. Feel free to let me know if anything is funky with this! I always love feedback.

hai-cea pushed a commit that referenced this pull request Jan 13, 2015
Adds componentWillReceiveProps to Toggle component
@hai-cea hai-cea merged commit 5391c80 into mui:master Jan 13, 2015
@hai-cea
Copy link
Member

hai-cea commented Jan 13, 2015

Hi @seanders - Thanks for the this PR.

BTW, we're going to be revamping the toggle component very soon by tying this component to a checkbox element. We're still working out the kinks with the implementation - see #233, but hopefully, it will result in a more robust and easier to use component.

@seanders seanders deleted the toggle_receive_props branch January 13, 2015 18:06
@zannager zannager added the component: toggle button This is the name of the generic UI component, not the React module! label Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: toggle button This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Toggle doesn't update based on new props
3 participants