Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds titleStyle prop to AppBar #2324

Merged
merged 2 commits into from
Dec 1, 2015

Conversation

rolandpoulter
Copy link
Contributor

Need to be able to override title element styles in AppBar. In my case I didn't want overflow: hidden so that I could put a drop down menu in the title.

@oliviertassinari
Copy link
Member

In my case I didn't want overflow: hidden so that I could put a drop down menu in the title.

This will be fixed by #2150.

But, yes, I think that we should be able to override the style 👍 .
Could you add it to the documentation too?

@oliviertassinari oliviertassinari added the PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI label Nov 30, 2015
@rolandpoulter
Copy link
Contributor Author

@oliviertassinari maybe if I was using the one from material-ui, but in my case I am using react-select.

I'm not sure that #2150 would fix this particular issue either. Depends on if the Popover gets appended inside the title element or not.

@oliviertassinari
Copy link
Member

Popover gets appended inside the title element or not.

Yes, he does get appended outside.

@oliviertassinari oliviertassinari added Review: accepted and removed PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI labels Dec 1, 2015
@oliviertassinari
Copy link
Member

@rolandpoulter Thanks!

oliviertassinari added a commit that referenced this pull request Dec 1, 2015
@oliviertassinari oliviertassinari merged commit f80584d into mui:master Dec 1, 2015
@rolandpoulter rolandpoulter deleted the custom-title-styles branch December 7, 2015 20:07
@zannager zannager added the component: app bar This is the name of the generic UI component, not the React module! label Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: app bar This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants