Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Improve icon preview color contrast #22974

Merged
merged 1 commit into from
Oct 11, 2020
Merged

[docs] Improve icon preview color contrast #22974

merged 1 commit into from
Oct 11, 2020

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Oct 10, 2020 •
edited
Loading

I have found the issue opening the page inside VSCode. The light mosaic in a dark theme was really ugly.

Before
Capture d’écran 2020-10-10 à 22 33 06

After
Capture d’écran 2020-10-10 à 22 32 03

Before
Capture d’écran 2020-10-10 à 22 33 01

After
Capture d’écran 2020-10-10 à 22 32 08

@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Oct 10, 2020
@mui-pr-bot
Copy link

No bundle size changes comparing 6c22660...1c3956a

Generated by 🚫 dangerJS against 1c3956a

@oliviertassinari oliviertassinari merged commit 66f3a23 into mui:next Oct 11, 2020
@oliviertassinari oliviertassinari deleted the icons-preview-dark-mode branch October 11, 2020 13:59
@oliviertassinari
Copy link
Member Author

Was done for #19697 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbrookes mbrookes mbrookes approved these changes

@joshwooding joshwooding joshwooding approved these changes

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@oliviertassinari @mui-pr-bot @mbrookes @joshwooding