[LeftNav] swipeable only from the far left (or right) area of the page #2263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (!this.state.open) { | ||
| if (this.props.openRight) { | ||
| // If openRight is true calculate from the far right | ||
| if (e.touches[0].pageX < document.body.offsetWidth - 30) return; |
There was a problem hiding this comment.
Can you use a constant variable for the 30?
alitaheri
force-pushed
the
left-nav-limit-swipe-area
branch
from
f3da463 to
8447fa8
Compare
|
@oliviertassinari Please check again. |
alitaheri
changed the title
|
@subjectix Thanks 👍 |
oliviertassinari
added a commit
that referenced
this pull request
Nov 26, 2015
[LeftNav] swipeable only from the far left (or right) area of the page
|
Thank you ^.^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1384.
Only swipe open the LeftNav from far left or far right.